Expand Hostname Buffer #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buffer holding the results for gethostname now contains HOST_NAME_MAX + 1 characters so it may contain hostnames at HOST_NAME_MAX printable characters and a terminating null. Prior to this change, the buffer could only accomodate hostnames of HOST_NAME_MAX - 1 characters.
dasJ
added a commit
to helsinki-systems/libspf2
that referenced
this pull request
Aug 11, 2021
This merges shevek#17 * pull/17: Expand Hostname Buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer holding the results for gethostname now contains
HOST_NAME_MAX + 1 characters so it may contain hostnames at
HOST_NAME_MAX printable characters and a terminating null.
Prior to this change, the buffer could only accomodate hostnames
of HOST_NAME_MAX - 1 characters.
If you had a hostname that was HOST_NAME_MAX (64 characters on Linux)
with the old buffer, the call to gethostname(...) would succeed but truncate
the hostname (the truncation behavior is not fully specified, according to
the GETHOSTNAME(2) man page). On my platform, this led to a zero length
hostname which caused subsequent failures.