New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing silent failure while creating the hooks #35

Merged

orta merged 2 commits into shibapm:master from dirtyhenry:fix-silent-fail

Oct 10, 2020

Contributor

dirtyhenry commented Sep 9, 2020 •

edited

Hi, and thanks for this awesome project.

I had issues when I tried to install Komondor on a Xcode project of mine and this pull request aims to fix what went wrong:

Some docs were out of date;
At first, the hooks were not created but were logged as they were;
Then using a URL directly without going through absoluteString fixed it for me (and, funny anecdote, it was about the same fix that I suggested on this StackOverflow question, a couple of weeks ago).

All in all, quite small changes, and now my setup works great! 🙏

dirtyhenry added 2 commits

September 9, 2020 13:28


          Update documentation typos

f7b0dbd


          Fix issue when creating assets failed silently

07fea31

Member

orta commented Oct 10, 2020

Agree to all of it - sorry it took a while

orta merged commit 1d9dd4e into shibapm:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment