This is the change for single precision functions equivalent to the p… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revious branches for improving performance of asin, acos, log_u1, etc. functions.
|
Please take time to review the code. |
fpetrogalli
requested changes
Apr 20, 2017
src/libm/sleefsimdsp.c
Outdated
| @@ -1091,11 +1179,11 @@ static INLINE CONST vfloat expkf(vfloat2 d) { | |||
| EXPORT CONST vfloat xpowf(vfloat x, vfloat y) { | |||
| #if 1 | |||
| vopmask yisint = vor_vo_vo_vo(veq_vo_vf_vf(vtruncate_vf_vf(y), y), vgt_vo_vf_vf(vabs_vf_vf(y), vcast_vf_f(1 << 24))); | |||
| vopmask yisodd = vand_vo_vo_vo(vand_vo_vo_vo(veq_vo_vi2_vi2(vand_vi2_vi2_vi2(vtruncate_vi2_vf(y), vcast_vi2_i(1)), vcast_vi2_i(1)), yisint), | |||
| vopmask yisodf = vand_vo_vo_vo(vand_vo_vo_vo(veq_vo_vi2_vi2(vand_vi2_vi2_vi2(vtruncate_vi2_vf(y), vcast_vi2_i(1)), vcast_vi2_i(1)), yisint), | |||
There was a problem hiding this comment.
Did you just change the variable name? What for? I don't think this is needed. Please revert it.
src/libm/sleefsimdsp.c
Outdated
| @@ -1366,9 +1454,9 @@ EXPORT CONST vfloat xroundf(vfloat d) { | |||
|
|
|||
| EXPORT CONST vfloat xrintf(vfloat d) { | |||
| vfloat x = vadd_vf_vf_vf(d, vcast_vf_f(0.5f)); | |||
| vopmask isodd = veq_vo_vi2_vi2(vand_vi2_vi2_vi2(vcast_vi2_i(1), vtruncate_vi2_vf(x)), vcast_vi2_i(1)); | |||
| vopmask isodf = veq_vo_vi2_vi2(vand_vi2_vi2_vi2(vcast_vi2_i(1), vtruncate_vi2_vf(x)), vcast_vi2_i(1)); | |||
There was a problem hiding this comment.
No reason to change variable name here.
shibatch
deleted the
Performance_improvement_for_asinf,_acosf,_logf_u1,_etc
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…revious branches for improving performance of asin, acos, log_u1, etc. functions.
I will also modify the benchmarking tools if performance number is needed.