Use Recycle Bin name only on Windows #388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
* Theme Scrollbars Updated scrollbars to match windows webkit styling for both light and dark mode * Update _scroll.scss Separating linux from win32 reference, in case we want to adjust for the future and not impact the other * Updated Scroll Color and Docs Adding color change to dark theme scroll bars merged upstream, and updating documentation related to editor and shell updates
Reduce errors produced in terminal from debian package installations by testing for existence of symlink prior to executing unlink
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories. This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
On Linux Mint I see "Recycle Bin" on the dialog box when it should be "Trash." This PR changes the label such that "Recycle Bin" only appears on Windows and "Trash" appears for everything else. I haven't tested if this will actually fix the problem since I don't have the ability to build this, so feel free to decline the pull request if it's an inappropriate fix. Thanks.
|
@hydrogen-mvm thanks for the contribution. Rather than rewriting the PR and re-running CI I cherry-picked the key commit into 4d21148 which is now on the main branch. This will be included in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux Mint I see "Recycle Bin" on the dialog box when it should be "Trash."
https://i.imgur.com/TPAKaCH.png
This PR changes the label such that "Recycle Bin" only appears on Windows and "Trash" appears for everything else. I haven't tested if this will actually fix the problem since I don't have the ability to build this, so feel free to decline the pull request if it's an inappropriate fix.
Thanks.