Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux About Modal #241

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Linux About Modal #241

merged 2 commits into from
Mar 30, 2020

Conversation

jfgordon2
Copy link

Description

Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replaced with a link to the linux releases page

Screenshots

image

Release notes

Notes: Removed the 'check for updates' button, and replaced with a link to the unofficial linux releases page.

@jfgordon2
Linux About Modal
6d3c46c 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
@shiftkey shiftkey self-assigned this Mar 30, 2020
shiftkey
shiftkey reviewed Mar 30, 2020
View reviewed changes
Copy link
Owner

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions to tidy this up, otherwise this is 💎

app/src/ui/about/about.tsx Outdated Show resolved Hide resolved
app/src/ui/about/about.tsx Outdated Show resolved Hide resolved
@jfgordon2
Clean Up
a87d7a9 
Updated to consolidate import and removed the word "Linux" from the release link
shiftkey
shiftkey approved these changes Mar 30, 2020
View reviewed changes
Copy link
Owner

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the polish here @jfgordon2!

@shiftkey shiftkey merged commit d3af78d into shiftkey:linux Mar 30, 2020
@jfgordon2 jfgordon2 deleted the patch-about branch March 30, 2020 17:13
shiftkey pushed a commit that referenced this pull request Apr 2, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
734933f 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Apr 6, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
354e8db 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Apr 6, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
8642e9c 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Apr 6, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
b1251ec 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
@shiftkey shiftkey mentioned this pull request Apr 6, 2020
Merged
shiftkey pushed a commit that referenced this pull request Apr 6, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
dd51237 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Apr 16, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
7b88cc9 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Apr 16, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
f756b61 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Apr 16, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
15ed706 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Apr 17, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
20fd094 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Apr 23, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
a4b78e5 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Apr 28, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
e1e445a 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Apr 29, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
f084427 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request May 1, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
e9c38c5 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request May 1, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
ae55bed 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request May 2, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
c0d4ccd 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request May 2, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
24e3374 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request May 12, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
683f226 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request May 12, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
eca783e 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request May 12, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
1aabc03 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request May 15, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
413bec0 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request May 16, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
229dab3 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request May 18, 2020
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
41e3dab 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Jul 1, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
2cb68f8 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Jul 1, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
8a23827 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Jul 1, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
ce6bc2c 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Jul 13, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
cad93a0 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 10, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
4501777 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 10, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
647e296 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 10, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
25dae7b 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
192afb2 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
12057a0 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
99c5213 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
334a4f6 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
673596c 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
e3aa148 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
f899f26 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
206e846 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
d3744f3 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
69f3b8a 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
156bdc1 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
polish About modal for Linux build (#241)
d835cf5 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
8a8e839 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 14, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
403b0a0 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 15, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
0aabcc4 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 17, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
e89a095 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Aug 17, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
1f3d45a 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Sep 2, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
e0c4fa5 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Oct 30, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
5b59f24 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
fa71bab 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
3e7352f 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
db28975 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@jfgordon2 @shiftkey
fix: update About modal by hiding unsupported features on Linux (#241)
d0ddcad 
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftkey shiftkey shiftkey approved these changes

Assignees

@shiftkey shiftkey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfgordon2 @sarim @shiftkey