Question about _fetchJSONAssets

[banga]

Hello again,

I'm wondering why _fetchJSONAssets uses jsonc-parser instead of JSON.parse. It looks like all of the bundled themes and languages are valid JSON:

find ./packages/shiki/ -name "*.json" | \
  grep -e "\(languages\|themes\)" | \
  xargs -n1 -I{} node -e "JSON.parse(fs.readFileSync('{}','utf-8'))"

_fetchJSONAssets takes around 300ms right now, but switching it to JSON.parse brings it down to 30ms. I ask because this is the source of a noticeable delay in start up time for https://github.com/banga/git-split-diffs.

[orta]

It was before my time, but I'd guess because the vscode parser uses jsonc then folks probably add comments to the JSON files - there could maybe be a processing step in this repo to allow them to be converted to something JSON.parse could handle during a deploy though

[banga]

I see, yeah that would be great (unless people supply their own language/theme files at runtime). Another option is that we try JSON.parse and then fall back to jsonc-parser if it throws. I'd be happy to put up a PR for that, if that sounds good to you.

[orta]

I think trying JSON parse then falling back is a good answer 👍🏻

[DanielRosenwasser]

That 270ms difference is surprising - I wonder if VS Code itself tries to side-step that.