Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about custom vscode-textmate dependency #62

Closed
oovm opened this issue Aug 9, 2020 · 4 comments
Closed

Question about custom vscode-textmate dependency #62

oovm opened this issue Aug 9, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@oovm
Copy link
Contributor

oovm commented Aug 9, 2020

shiki/packages/shiki/package.json

Lines 19 to 24 in 56c230a

"dependencies": {
"onigasm": "^2.2.1",
"shiki-languages": "^0.1.6",
"shiki-themes": "^0.1.7",
"vscode-textmate": "https://github.com/octref/vscode-textmate"
}

What is the function of the self-built dependency here, can it be upgraded to textmate5?
@octref
Copy link
Collaborator

octref commented Aug 17, 2020

For microsoft/vscode-textmate#79, now it's possible to update.

@octref octref added the bug Something isn't working label Aug 17, 2020
@octref octref changed the title Question about dependencies Question about custom vscode-textmate dependency Aug 17, 2020
@octref
Copy link
Collaborator

octref commented Aug 18, 2020

Upgraded and all seems good.

@octref octref closed this as completed in 5845e2a Aug 18, 2020
@oovm
Copy link
Contributor Author

oovm commented Aug 26, 2020

Also remove here:

shiki/packages/languages/package.json

Lines 19 to 21 in 12accaa

"dependencies": {
"vscode-textmate": "https://github.com/octref/vscode-textmate"
}

@octref
Copy link
Collaborator

octref commented Aug 26, 2020

OK, removed.

octref added a commit that referenced this issue Aug 26, 2020
@octref
Remove custom vscode-textmate dependency for #62
d40a401
antfu added a commit that referenced this issue Jan 26, 2024
@antfu
docs: use floating-vue to display type info (#62)
f681161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@octref @oovm