Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic node_module resolution for wasm path #412

Closed

Conversation

muenzpraeger
Copy link
Collaborator

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 928814b
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/63c14a37cd889d0008db0ddc
😎 Deploy Preview https://deploy-preview-412--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Nedilko
Copy link

Nedilko commented Jan 16, 2023

really waiting you to fix this

@selenecodes
Copy link

Same, my react server-side components can't use rehype-pretty-code due to this issue.

@Nedilko
Copy link

Nedilko commented Jan 16, 2023

Same, my react server-side components can't use rehype-pretty-code due to this issue.

as a temporary fix I apply this

@Nedilko
Copy link

Nedilko commented Jan 16, 2023

thanks to @pengx17

@wooorm
Copy link
Contributor

wooorm commented Jan 16, 2023

Looks a bit frail to me, perhaps something like import-meta-resolve (but then I’m the author of that)?

@octref
Copy link
Collaborator

octref commented Jan 27, 2023

import-meta-resolve looks good. If all you want is shiki to work with next 13, you can see this sample: https://github.com/shikijs/next-shiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't load shiki vscode-oniguruma in Next 13 react server component
5 participants