New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: marko, mdx, vue #452
fix: marko, mdx, vue #452
Conversation
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This supersedes #447 (brings it from the original mdx-analyzer source). |
I’d recommend the URL from #447, that’s where it is maintained. That’s where discussion happens. That’s where changes happen. |
Didn't see this comment in the mdx file. My main concern is that it may conflict the statement:
if the release cycle of (Essentially, your repository is on, afaik, the bleeding edge while mdx-analyzer is the stable version). |
I don’t know where you quote “that looks exactly like your code in VS Code” from? |
In the shiki README's about section, it mentions that little statement. Because of that, I'm not sure whether to follow mdx-analyzer's stable version or your version. If the authors are fine with using your version (the actual source), then I'll drop the mdx fix in this PR and leave the maintainers to merge yours 👍 |
Ah, ok. I can’t comment on what the good folks here prefer! |
Co-authored-by: Titus Wormer <tituswormer@gmail.com>
Thanks! |
VS Code's grammars are just a baseline. If there are better grammars I'm totally cool with merging them. Thanks @wooorm and @LeoDog896 ! |
This PR fixes broken links to marko, mdx, and vue. They changed their repository layouts, leading to broken links.
The changes to
mdx
specifically are very impactful, as the link has been broken for some time.