Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: marko, mdx, vue #452

Merged
merged 2 commits into from Mar 28, 2023
Merged

fix: marko, mdx, vue #452

merged 2 commits into from Mar 28, 2023

Conversation

LeoDog896
Copy link
Contributor

This PR fixes broken links to marko, mdx, and vue. They changed their repository layouts, leading to broken links.

The changes to mdx specifically are very impactful, as the link has been broken for some time.

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 23a3215
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/64230594ed8a5600081f3cb0
😎 Deploy Preview https://deploy-preview-452--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@LeoDog896
Copy link
Contributor Author

This supersedes #447 (brings it from the original mdx-analyzer source).

@wooorm
Copy link
Contributor

wooorm commented Mar 28, 2023

I’d recommend the URL from #447, that’s where it is maintained. That’s where discussion happens. That’s where changes happen. mdx-analyzer will have a delay!

@LeoDog896
Copy link
Contributor Author

LeoDog896 commented Mar 28, 2023

Didn't see this comment in the mdx file. My main concern is that it may conflict the statement:

that looks exactly like your code in VS Code

if the release cycle of mdx-analyzer is different than your tm package. However, it sounds perfectly nice just as long as the authors agree.

(Essentially, your repository is on, afaik, the bleeding edge while mdx-analyzer is the stable version).

@wooorm
Copy link
Contributor

wooorm commented Mar 28, 2023

I don’t know where you quote “that looks exactly like your code in VS Code” from?

@LeoDog896
Copy link
Contributor Author

LeoDog896 commented Mar 28, 2023

In the shiki README's about section, it mentions that little statement. Because of that, I'm not sure whether to follow mdx-analyzer's stable version or your version.

If the authors are fine with using your version (the actual source), then I'll drop the mdx fix in this PR and leave the maintainers to merge yours 👍

@wooorm
Copy link
Contributor

wooorm commented Mar 28, 2023

Ah, ok. I can’t comment on what the good folks here prefer!

@orta
Copy link
Contributor

orta commented Mar 28, 2023

Yeah, lets go with @wooorm's - if you'd like to change it in this PR that's fine, otherwise you can remove it and I'll also accept #447

Co-authored-by: Titus Wormer <tituswormer@gmail.com>
@orta
Copy link
Contributor

orta commented Mar 28, 2023

Thanks!

@orta orta merged commit 2bff836 into shikijs:main Mar 28, 2023
2 checks passed
@orta orta mentioned this pull request Mar 28, 2023
@octref
Copy link
Collaborator

octref commented Mar 28, 2023

VS Code's grammars are just a baseline. If there are better grammars I'm totally cool with merging them. Thanks @wooorm and @LeoDog896 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants