feat: lisp family improvements: better grammar for Common Lisp; added Racket, Fennel, Hy #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "lisp" grammar provided by mattn/vscode-lisp (which is a slightly modified version of the one from TextMate) has some problems: - It seemingly treats Common Lisp and Emacs Lisp as the same language. This is as usable (or not) as using the same grammar to highlight C and old JavaScript (ES5 was probably close enough to C syntax for that to work): they have different builtins and different syntaxes in some areas, despite large similarities. - More concretely: it doesn't highlight &rest or &key; it highlights macros, functions and keywords (like `:hello`) the same; it has no support for highlighting format strings (which qingpeng9802/vscode-common-lisp does); it also doesn't highlight namespaces. By using the grammar from qingpeng9802/vscode-common-lisp, the highlighting for Common Lisp code becomes much better. This commit allows calling the language "common-lisp". An alias for "lisp" is still provided, as "lisp" as a specific language usually also refers to Common Lisp.
Hy needs a display name as it doesn't get capitalized properly in the playground (and presumbaly elsewhere) otherwise.
✅ Deploy Preview for textmate-grammars-themes ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kisaragi-hiu
changed the title
antfu
changed the title
antfu
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I grouped these changes into one PR as they are somewhat related and otherwise I would be about to open a dozen PRs.
The generated / converted / fetched files are added in a separate commit to make it easier to review and/or merge.
Changes in this PR: