Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitterのサブドメイン対応用Resolverを追加 #469

Merged
merged 1 commit into from
Aug 16, 2020

Conversation

shibafu528
Copy link
Member

fix #466

Twitterの思いつく限りのサブドメインを正規化してOGPResolverに横流しするResolverを追加。

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #469 into develop will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #469      +/-   ##
=============================================
- Coverage      38.48%   38.29%   -0.20%     
- Complexity       409      411       +2     
=============================================
  Files             75       76       +1     
  Lines           1572     1580       +8     
=============================================
  Hits             605      605              
- Misses           967      975       +8     
Impacted Files Coverage Δ Complexity Δ
app/MetadataResolver/MetadataResolver.php 0.00% <ø> (ø) 13.00 <0.00> (ø)
app/MetadataResolver/TwitterResolver.php 0.00% <0.00%> (ø) 2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca1645...04d546b. Read the comment docs.

@shibafu528 shibafu528 merged commit 867cafa into develop Aug 16, 2020
@shibafu528 shibafu528 deleted the fix/466-mobatwi branch August 16, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mobile.twitter.comに対応させる
2 participants