Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

非公開フラグ、センシティブフラグのCSVインポート・エクスポート対応 #473

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

shibafu528
Copy link
Member

@shibafu528 shibafu528 commented Aug 19, 2020

fix #365, fix #366

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #473 into develop will increase coverage by 0.58%.
The diff coverage is 73.07%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #473      +/-   ##
=============================================
+ Coverage      37.83%   38.42%   +0.58%     
- Complexity       418      434      +16     
=============================================
  Files             76       77       +1     
  Lines           1599     1624      +25     
=============================================
+ Hits             605      624      +19     
- Misses           994     1000       +6     
Impacted Files Coverage Δ Complexity Δ
app/Services/CheckinCsvExporter.php 0.00% <0.00%> (ø) 8.00 <2.00> (+2.00)
app/Rules/FuzzyBoolean.php 86.66% <86.66%> (ø) 12.00 <12.00> (?)
app/Services/CheckinCsvImporter.php 91.26% <100.00%> (+0.54%) 33.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d894897...915b575. Read the comment docs.

@shibafu528 shibafu528 merged commit 6f8c81c into develop Aug 19, 2020
@shibafu528 shibafu528 deleted the feature/365-csv-flags branch August 19, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant