Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v143(vc17) & OpenCV4.5.5 #1358

Merged
merged 19 commits into from Dec 31, 2021
Merged

v143(vc17) & OpenCV4.5.5 #1358

merged 19 commits into from Dec 31, 2021

Conversation

shimat
Copy link
Owner

@shimat shimat commented Dec 26, 2021

No description provided.

@shimat shimat added the enhancement New feature or request label Dec 26, 2021
@shimat shimat self-assigned this Dec 26, 2021
Copy link

@sdcb sdcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shimat , are we really going to drop net461? Because Visual Studio 2022 by default will create .NET 4.7.2 project, and looks like there isn't any technical conflictions here.

@shimat
Copy link
Owner Author

shimat commented Dec 29, 2021

The direct reason I'm changing the TargetFramework from net461 to net48 is because the GitHub Actions' windows-2022 runner does not have net461 installed. https://github.com/actions/virtual-environments/blob/main/images/win/Windows2022-Readme.md#net-framework

I will maintain the inclusion of netstandard2.0 in OpenCvSharp's TargetFramework, so I believe it is possible to continue using net461~net472. https://docs.microsoft.com/en-us/dotnet/standard/net-standard

@shimat shimat changed the title [WIP] v143 & OpenCV4.5.5 v143(vc17) & OpenCV4.5.5 Dec 31, 2021
@shimat shimat merged commit ba72f3e into master Dec 31, 2021
@shimat shimat deleted the 4.5.5 branch December 31, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants