-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions CI builds #183
Conversation
b5ac525
to
63b3a15
Compare
e427d61
to
f0ab33a
Compare
5994ca1
to
6fe852e
Compare
d157b55
to
1dda881
Compare
@jcohenadad I think it's good to go now. All the GH Actions runs are passing (love those green checkmarks 😁) and the Python version build matrix looks fine too!
The Coveralls builds run over all matrix builds now and I believe it averages coverage over each build parameter. 3.8 seems to have fewer lines run under the hood, giving it the appearance of having lower coverage. However, since the build matrix will be running in every PR CI check from now on, it's really just setting a new baseline coverage percentage that future PRs will be measured against. |
eb153a6
to
8692c85
Compare
20d6360
to
e5b5cbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked more closely at the builds and even though they say they pass, they all have errors within the CI run. I think its related to prelude and dcm2niix not being installed.
Oh good catch - maybe a |
Resolves #183 (review) Related to #180 **Why this change was necessary** The CI script was soldiering through without throwing an error code when individual steps failed. Additionally, the steps for dcm2niix installation did not work on the macOS builds. **What this change does** - Adds early exits to script if steps fail. - Sets up OS-dependent steps for dcm2niix installation
e5b5cbe
to
13955ea
Compare
Resolves #183 (review) Related to #180 **Why this change was necessary** The CI script was soldiering through without throwing an error code when individual steps failed. Additionally, the steps for dcm2niix installation did not work on the macOS builds. **What this change does** - Adds early exits to script if steps fail. - Sets up OS-dependent steps for dcm2niix installation
13955ea
to
970fede
Compare
Resolves #183 (review) Related to #180 **Why this change was necessary** The CI script was soldiering through without throwing an error code when individual steps failed. Additionally, the steps for dcm2niix installation did not work on the macOS builds. **What this change does** - Adds early exits to script if steps fail. - Sets up OS-dependent steps for dcm2niix installation
970fede
to
b6769d8
Compare
@po09i @jcohenadad I narrowed down the failing build to the macOS build needing the macOS |
Related to shimming-toolbox/shimming-toolbox#183 (review) **Why this change was necessary** Now that shimming-toolbox is including macOS in its CI, a different binary is needed for macOS CI testing. **What this change does** Adds a macOS prelude binary.
Related to shimming-toolbox/shimming-toolbox#183 (review) **Why this change was necessary** Now that shimming-toolbox is including macOS in its CI, a different binary is needed for macOS CI testing. **What this change does** Adds a macOS prelude binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cc17ac3
to
007bac1
Compare
Resolves #180 **Why this change was necessary** Travis doesn't offer great support for macOS and is also beginning to charge for macOS build minutes[1]. **What this change does** - Factors the Travis CI build config into a GH Actions Workflow - Adds a matrix build in the GH Actions Workflow for macOS 10.15 Catalina and 11.0 Big Sur (on x86_64 Intel chips), and Ubuntu 18, 20, and 16 - Adds a matrix build in the GH Actions Workflow for Python 3.7 and 3.8 - Adds a build status badge to the README - Adds Coveralls parallel build coverage metrics[2] **Additional context/notes/links** [1] https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing [2] https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-gotcha
007bac1
to
12a45c8
Compare
Resolves #180 **Why this change was necessary** Travis doesn't offer great support for macOS and is also beginning to charge for macOS build minutes[1]. **What this change does** - Factors the Travis CI build config into a GH Actions Workflow - Adds a matrix build in the GH Actions Workflow for macOS 10.15 Catalina and 11.0 Big Sur (on x86_64 Intel chips), and Ubuntu 18, 20, and 16 - Adds a matrix build in the GH Actions Workflow for Python 3.7 and 3.8 - Adds a build status badge to the README - Adds Coveralls parallel build coverage metrics[2] **Additional context/notes/links** [1] https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing [2] https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-gotcha
Checklist
Description
Why this change was necessary
Travis doesn't offer great support for macOS and is also beginning to
charge for macOS build minutes.
What this change does
Catalina and 11.0 Big Sur (on x86_64 Intel chips), and Ubuntu 18, 20, and
16
3.8
Additional context/notes/links
https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
Linked issues
Resolves #180