Convert st_plugin to package for fsleyes #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic python package setup
This prevents an unnecessary weight installed by users who probably don't want to run our unit tests; though it allows them to, if they read the (as yet unwritten) dev docs or get a tip from a developer helping them debug their install: just `pip install shimmingtoolbox[testing]`. This is the blessed method from the python packaging developers: pypa/setuptools#1684 (comment) The other(?) blessed method is to use tox's `deps` option: pypa/setuptools#931
Ubuntu Xenial still uses 3.6 and it's still alive for at least half a year more.
Identified the function calls and added context
Converted variable names to `snake_case`
These are based on the flowchart at https://www.shimming-toolbox.org/1_overview/2_flowchart/ (NB: that link will probably rot; the chart isn't screenshotable by archive.org either) but it's likely that they will be deleted and replaced by scripts that perform a larger block of the MRI shimming process in one step -- partly by calling the (currently empty) library functions also included here.
* Update to input static and riro mask * Update tests for rtzshim API * Update the CLI and tests for the CLI * Update the shell script to input both masks * Fix typo for shell script * Updated option names and added RIRO comment
* update docs and readme for new dcm2niix version * Fix the version number in docs * update > to >=
po09i
force-pushed
the
ah/plugin-package
branch
from
d4c7c81
to
1a1a71a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Linked issues
#241