upgrade npm modules, add superagent sample and enable postcss #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimomuh
commented
May 5, 2018
| "postcss-loader": "2.1.5", | ||
| "sass-loader": "7.0.1", | ||
| "style-loader": "0.21.0", | ||
| "webpack": "4.7.0", |
| "extract-text-webpack-plugin": "3.0.2", | ||
| "flow-bin": "0.66.0", | ||
| "css-loader": "0.28.11", | ||
| "extract-text-webpack-plugin": "4.0.0-beta.0", |
There was a problem hiding this comment.
webpack 4 に伴い extract-text-webpack-plugin もアップデート。
ただし、通常の最新版は webpack 4 に対応していない。
そこで、 extract-text-webpack-plugin@next を利用することで対応した。
| } | ||
| ) | ||
|
|
||
| module.exports = { plugins: [autoprefixer] } |
There was a problem hiding this comment.
loader はいたが、設定ファイルがなかったので、配置して有効化
| return resolve({ data: res.body, status: res.status }) | ||
| }) | ||
| }) | ||
| } |
There was a problem hiding this comment.
XHR 関連メソッド。
adapter として定義しているが、サンプルでは利用していない
| // const { data } = yield call(XHRpost, '/test', payload) | ||
| // yield put(CounterRedux.creators.reset(data)) | ||
| // } | ||
| //} |
There was a problem hiding this comment.
サンプル。
利用シーンがなかったので、コメントアウト。
| @@ -32,9 +32,6 @@ const javascript = { | |||
| plugins: [ | |||
| new webpack.ProvidePlugin({ | |||
| 'React': 'react' | |||
| }), | |||
| new webpack.optimize.CommonsChunkPlugin({ | |||
| name: 'javascripts/commons/chunk' | |||
There was a problem hiding this comment.
webpack4 で違う記述になったが、小さなコンポーネントなので、 optimization のオプションはつけず削除する方に倒した
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
掲題の通り
ダイジェストは以下。