Add fb-text-to-download partner page #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create FB ad landing page
update copy on fb ad page & bg img
Remove GA properties around button in signup form
jonuy
reviewed
Nov 7, 2018
| imageUrl: '/images/confirmation-header-happy-dance.gif', | ||
| copy: "You're all signed up!", | ||
| }, | ||
| campaignKey: 'OPC242EB5AF6EFE8477E4BEC73301BA67F', |
There was a problem hiding this comment.
Do you know if we've got final copy setup in Mobile Commons?
| @@ -1,7 +1,7 @@ | |||
| font-size: @font-size-homepage-normal; | |||
|
|
|||
| .container-partners-lead { | |||
| @container-partner-lead-height: 960px; | |||
| @container-partner-lead-height: 800px; | |||
There was a problem hiding this comment.
Does this styling change and the one on line 59 work ok on the other partner pages?
There was a problem hiding this comment.
yep, they look fine to me.
as the screen size gets bigger (ie larger than usual desktop monitors), the img gets cropped more and more but for all the major devices we serve content to, things look ok to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s this PR do?
How was this tested? How should this be reviewed?
What are the relevant tickets?
Questions / Considerations