Skip to content

Commit

Permalink
vm_args.c: refined warning splat to var
Browse files Browse the repository at this point in the history
* vm_args.c (setup_parameters_complex): refine the warning message
  for a splat hash which was passed to a single variable instead
  of keyword arguments.  this behavior will be changed when the
  "real" keyword argument is introduced in the future.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63540 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
  • Loading branch information
nobu committed May 31, 2018
1 parent a627388 commit fef8339
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions vm_args.c
Expand Up @@ -671,8 +671,15 @@ setup_parameters_complex(rb_execution_context_t * const ec, const rb_iseq_t * co
argument_kw_error(ec, iseq, "unknown", rb_hash_keys(keyword_hash));
}
else if (kw_splat && NIL_P(keyword_hash)) {
rb_warning("passing splat keyword arguments as a single Hash"
" to `% "PRIsVALUE"'", rb_id2str(ci->mid));
if (RTEST(ruby_verbose)) {
VALUE path = rb_iseq_path(iseq);
VALUE line = rb_iseq_first_lineno(iseq);
VALUE label = rb_iseq_label(iseq);
rb_compile_warning(NIL_P(path) ? NULL : RSTRING_PTR(path), FIX2INT(line),
"in `%s': the last argument was passed as a single Hash",
NIL_P(label) ? NULL : RSTRING_PTR(label));
rb_warning("although a splat keyword arguments here");
}
}

if (iseq->body->param.flags.has_block) {
Expand Down

0 comments on commit fef8339

Please sign in to comment.