Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ShinyBleBroadcastReceiver.cs #579

Merged
merged 2 commits into from May 7, 2021
Merged

Update ShinyBleBroadcastReceiver.cs #579

merged 2 commits into from May 7, 2021

Conversation

maxDev-Dev
Copy link
Contributor

Hello,
Without this event filter, the OnConnected method in BleDelegate is never called

Description of Change

Add new Filter event BluetoothDevice.ActionAclConnected

Issues Resolved

  • fixes #

API Changes

None

Platforms Affected

  • All
  • iOS
    x Android
  • UWP

Behavioral Changes

OnConnected method in BleDelegate is called

Testing Procedure

  1. Use BleClient with Delegate
  2. Connect to a bluetooth device
  3. now the OnConnect method would have to be called which is not the case

PR Checklist

  • [x ] Rebased on top of the target branch at time of PR
  • [x ] Changes adhere to coding standard

@aritchie aritchie changed the base branch from master to dev May 7, 2021 13:05
@aritchie aritchie merged commit 74d2857 into shinyorg:dev May 7, 2021
@aritchie
Copy link
Member

aritchie commented May 7, 2021

Thanks for the fix

@maxDev-Dev
Copy link
Contributor Author

Please that's a really nice framework Thank you

@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxDev-Dev @aritchie