Extract Attributes into its own plugin #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
simplify_backend_plugin
branch
from
9e0c651
to
6b1cf45
Compare
|
In passing, I'll mention the only place I could find that actually explains the return values of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's it, now basically everything is a plugin.
Also, previously when calling methods like
mobility_attributes, we'dgrepall modules which are instances ofMobility::Attributes, grab theirnamesand merge/flatten them. Same idea for backend classes. With this PR, we instead keep a running copy of what they are in an array, and add to it. Same for backend classes except we merge (since backend classes is a hash of keys->class).Also: removed
BackendCache, we don't need it.