updated travis and babel versions, as well as dependencies #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "@babel/preset-react": "^7.0.0", | ||
| "babel-eslint": "^10.0.1", | ||
| "babel-loader": "^8.0.6", | ||
| "babel-preset-env": "^1.7.0", |
There was a problem hiding this comment.
This is duplicated. Please go through all the dev and dependencies, and ensure there are not duplicated.
There was a problem hiding this comment.
moved non @babel devDependencies to dependencies
isuttell
requested changes
Jun 14, 2019
| "babel-loader": "^8.0.6", | ||
| "babel-preset-env": "^1.7.0", | ||
| "babel-preset-react": "^6.24.1", | ||
| "babel-runtime": "^6.26.0", |
There was a problem hiding this comment.
This one should actually be in the dependencies see https://babeljs.io/docs/en/babel-runtime#usage
isuttell
approved these changes
Jun 14, 2019
ThinkTankShark
requested changes
Jun 17, 2019
| "@babel/core": "^7.4.5", | ||
| "@babel/plugin-transform-runtime": "^7.4.4", | ||
| "@babel/preset-env": "^7.4.5", | ||
| "@babel/preset-react": "^7.0.0", |
There was a problem hiding this comment.
cut and paste this and preset-env into dependencies section
| "react": "^15.6.1", | ||
| "react-dom": "^15.6.1" | ||
| "babel-loader": "^8.0.6", | ||
| "babel-preset-env": "^1.7.0", |
There was a problem hiding this comment.
remove this, and preset-react
ThinkTankShark
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have to be changed everytime yeoman is run to generate a new ship-component. Just make sure 'npm install' works without throwing errors and such, and it should be good?