Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've upgraded a dependency and got test failures.
It looks like this version isn't compatible with your project right now. Please take a look at the exact failure to figure out if this is something you need to work on.
What changed?
✳️ rubocop ( → 0.59.2) · Repo · Changelog
Release Notes
0.59.2
Bug fixes
Rails/HasManyOrHasOneDependent
when using associations of Active Resource. (@tejasbubane, @koic)Style/For
when settingEnforcedStyle: each
andfor
dose not havedo
or semicolon. (@autopp)Layout/EmptyLineAfterGuardClause
when guard clause including heredoc. (@koic)AllowURI
option forMetrics/LineLength
cop with disabledLayut/Tab
cop. (@AlexWayfer)Metrics/BlockLength
into the respective length cops. (@drenmi)Style/ZeroLengthPredicate
false positives when inspectingTempfile
,StringIO
, andFile::Stat
objects. (@drenmi)Layout/EmptyLinesAroundAccessModifier
andLayout/EmptyLinesAroundAccessModifier
when specifying a superclass that breaks the line. (@koic)Style/IfUnlessModifier
when using named capture. (@drenmi)Style/Semicolon
from breaking on single line if-then-else in assignment. (@drenmi)Rails/HasManyOrHasOneDependent
when an Active Record model does not have any relations. (@koic)Style/For
when settingEnforcedStyle: each
with range provided to thefor
loop without ado
keyword or semicolon and without enclosing parenthesis. (@lukasz-wojcik)Changes
Metrics/MethodLength
. (@akanoi)0.59.1
Bug fixes
Rails/FindEach
. (@Knack)Naming/FileName
when investigating gemspecs. (@kddeisz)Naming/FileName
when investigating dotfiles. (@sinsoku)Style/EmptyCaseCondition
auto-correction removes comment betweencase
and firstwhen
. (@koic)Style/RedundantBegin
when callingsuper
with a block. (@eitoball)Layout/EmptyLineAfterGuardClause
when guard clause is after heredoc including string interpolation. (@koic)Style/MultilineMethodSignature
. (@drenmi)Layout/EmptyLineAfterGuardClause
cop whenif
condition is after heredoc. (@koic)Changes
Lint/UnreachableCode
detectexit
,exit!
andabort
. (@hoshinotsuyoshi)#===
fromNaming/BinaryOperatorParameterName
. (@zverok)+
to allowed file names ofNaming/FileName
. (@yensaki)0.59.0
New features
Bundler/GemComment
cop. (@sunny)IgnoredMethods
option toStyle/NumericPredicate
cop. (@AlexWayfer)--display-only-fail-level-offenses
to only output offenses at or above the fail level. (@robotdana)Style/For
. (@rrosenblum)AllowImplicitReturn
option toRails/SaveBang
cop. (@robotdana)comparison
style toStyle/NilComparison
. (@khiav223577)Style/MultilineMethodSignature
cop. (@drenmi)Performance/ChainArrayAllocation
cop. (@schneems)Layout/EmptyLinesAroundClassBody
aware of specifying a superclass that breaks the line. (@koic)Bug fixes
Style/DateTime
not detecting#to_datetime
. It can be configured to allow this. (@bdewater)Naming/FileName
whenInclude
ofAllCops
is the default setting. (@koic)Layout/MultilineOperationIndentation
. (@jonas054)Layout/ClosingParenthesisIndentation
when method arguments are empty with newlines. (@tatsuyafw)Layout/AccessModifierIndentation
when using access modifiers with arguments within nested classes. (@gmalette)Style/IfUnlessModifier
cop for disabledLayout/Tab
cop when there is noIndentationWidth
config. (@AlexWayfer)AllowURI
option ofMetrics/LineLength
cop for files with tabs indentation. (@AlexWayfer)Style/UnneededCondition
when using operator method higher precedence than||
. (@koic)Lint/ShadowedArgument
. (@jonas054)Layout/MultilineHashBraceLayout
andLayout/MultilineArrayBraceLayout
auto-correct syntax error when there is a comment on the last element. (@bacchir)Style/BracesAroundHashParameters
auto-correct syntax error when there is a trailing comma. (@bacchir)Style/RedundantBegin
aware of stabby lambdas. (@drenmi)Naming/PredicateName
. (@sunny)Style/EmptyCaseCondition
when usingreturn
inwhen
clause and assigning the return value ofcase
. (@koic)Rails/Delegate
. (@sunny)Style/WordArray
when settingEnforcedStyle: brackets
and using string interpolation in%W
literal. (@koic)Lint/RescueEnsureAlignment
whenend
is misaligned. The alignment and message are now based on the beginning position rather than theend
position. (@rrosenblum)Date
usage inStyle/DateTime
. (@deivid-rodriguez)Changes
Rails/FindEach
cop. Makes the cop also check for the following scopes:eager_load
,includes
,joins
,left_joins
,left_outer_joins
,preload
,references
, andunscoped
. (@repinel)db
to allowed names ofNaming/UncommunicativeMethodParamName
cop in default config. (@mkenyon)Lint/DuplicateMethods
to include the method name. (@rrosenblum)rubocop --auto-gen-conf
if the todo file is successfully created even if there are offenses. (@MagedMilad)Rails/RelativeDateConstant
by default. (@koic)*
) to match the hidden file. (@koic)Style/For
now highlights the entire statement rather than just the keyword. (@rrosenblum)Performance/CaseWhenSplat
and its auto-correction by default. (@rrosenblum)Layout/EmptyLineAfterGuardClause
cop by default. (@koic)Style/DateTime
has been moved to disabled by default. (@deivid-rodriguez)0.58.2
Changes
New features
#6105: Support
{a,b}
file name globs inExclude
andInclude
config. (@mikeyhew)#6116: Add
ip
to allowed names ofNaming/UncommunicativeMethodParamName
cop in default config. (@nijikon)Bug fixes
Layout/IndentationWidth
when multiple modifiers are used in a block and a method call is made at end of the block. (@koic)Naming/MemoizedInstanceVariableName
cop to allow methods to have leading underscores. (@kenman345)Layout/ClassStructure
when there is a comment in the macro method to be auto-correct. (@koic)Lint/OrderedMagicComments
when using{ encoding: Encoding::SJIS }
hash object afterfrozen_string_literal
magic comment. (@koic)0.58.1
Bug fixes
Style/MethodCallWithArgsParentheses
when arguments are method calls. (@maxh)Style/RedundantParentheses
with hash literal as first argument tosuper
. (@maxh)Gemspec/OrderedDependencies
when using method call to gem names in gemspec. (@koic)Rails/BulkChangeTable
aware of variable table name. (@wata727)Layout/MultilineAssignmentLayout
cop when using multi-line block defines on separate lines. (@koic)0.57.2
Bug fixes
Layout/ClosingHeredocIndentation
from raising an error on<<
heredocs. (@dvandersluis)Layout/ClosingHeredocIndentation
from raising an error on heredocs containing only a newline. (@drenmi)Layout/IndentationConsistency
cop triggered by an empty expression string interpolation. (@alexander-lazarov)Style/MethodCallWithArgsParentheses
from raising an error in certain cases. (@drenmi)0.57.1
Bug fixes
inherit_mode
directive. (@jonas054)Layout/IndentationWidth
when an access modifier section has an invalid indentation body. (@tatsuyafw)Layout/IndentationConsistency
should still register an offense for private methods. (@jaredbeck)Rails/BulkChangeTable
. (@wata727)Style/UnneededCondition
cop accepts a case of condition andif_branch
are same when usingelsif
branch. (@koic)0.57.0
New features
Rails/BulkChangeTable
cop. (@wata727)Style/AccessModifierDeclarations
cop. (@brandonweiss)Style/UnneededCondition
cop. (@balbesina)Layout/ClosingHeredocIndentation
cop. (@siggymcfried)slashes
style toRails/FilePath
since Ruby accepts forward slashes even on Windows. (@sunny)Layout/LeadingBlankLines
checks for empty lines at the beginning of a file. (@rrosenblum)Bug fixes
Style/SymbolArray
andStyle/WordArray
not working on arrays of size 1. (@TikiTDO)Rails/AssertNot
to allow it to have failure message. (@koic)headers
orenv
keyword arguments inRails/HttpPositionalArguments
. (@rrosenblum)Style/BracesAroundHashParameters
auto-correct going past the end of the file when the closing curly brace is on the last line of a file. (@EiNSTeiN-)Style/FrozenStringLiteralComment
would be added to the second line if the first line is empty. (@rrosenblum)Layout/SpaceInsideReferenceBrackets
aware ofno_space
when using nested reference brackets. (@koic)Style/MixinGrouping
when method namedinclude
accepts block. (@Darhazer)Changes
--fix-layout/-x
command line alias. (@scottmatthewman)Lint/SplatKeywordArguments
cop. (@koic)httpdate
to acceptedRails/TimeZone
methods. (@cupakromer)xmlschema
to acceptedRails/TimeZone
methods. (@koic)rake repl
task tobin/console
command. (@koic)inherit_mode
work for default configuration too. (@jonas054)unicode/display_width
. (@nroman-stripe)0.56.0
New features
Performance/InefficientHashSearch
cop. (@JacobEvelyn)Rails/RefuteMethods
cop. (@koic)Rails/AssertNot
cop. (@composerinteralia)Layout/ClosingParenthesisIndentation
detection including method chaining. (@jfelchner)consistent_relative_to_receiver
style option toLayout/FirstParameterIndentation
. (@jfelchner)AR::Migration#up_only
forRails/ReversibleMigration
cop. (@koic)Lint/ErbNewArguments
cop. (@koic)Lint/SplatKeywordArguments
cop. (@koic)Include
,Exclude
and the newRubyInterpreters
parameters for file selection. (@jonas054)Bug fixes
Style/EmptyMethod
which concatenated the method name and first argument if no method def parentheses are used. (@thomasbrus)Rails/SaveBang
when using negated if. (@Edouard-chin)Lint/SafeNavigationChain
not detecting chained operators after block. (@Darhazer)Lint/SafeNavigationConsistency
registers multiple offenses for the same method call. (@rrosenblum)Style/CommentAnnotation
reporting only the first of multiple consecutive offending lines. (@svendittmer)Lint/SafeNavigationConsistency
when there is code around the condition. (@rrosenblum)Rails/HasManyOrHasOneDependent
when using nestedwith_options
. (@koic)--stdin
always treats input as Ruby source irregardless of filename. (@PointlessOne)Style/MethodCallWithArgsParentheses
adding extra parentheses if the method argument was already parenthesized. (@dvandersluis)AllCops/Include
were not inspected when passing the file name as an option. (@drenmi)Lint/PercentStringArray
andLint/PercentSymbolArray
when the inspected file is binary encoded. (@akhramov)nil
responds to inLint/SafeNavigationConsistency
. (@rrosenblum)Lint/LiteralInInterpolation
if contains numbers. (@koic)Rails/CreateTableWithTimestamps
when using hash options. (@wata727)Lint/UnneededCopEnableDirective
for instruction '# rubocop:enable all'. (@balbesina)Rails/HttpPositionalArgumnets
to usesession
instead ofheader
. (@rrosenblum)Changes
Style/MethodMissing
into two cops,Style/MethodMissingSuper
andStyle/MissingRespondToMissing
. (@rrosenblum)AllowInMultilineConditions
option toStyle/ParenthesesAroundCondition
cop. (@Darhazer)Layout/SpaceInsideReferenceBrackets
when assigning a reference bracket to a reference bracket. (@joshuapinter)--auto-correct
. (@jonas054)try!
to the list of whitelisted methods forLint/SafeNavigationChain
andStyle/SafeNavigation
. (@rrosenblum)Style/EmptyLineAfterGuardClause
cop toLayout
department. (@koic)0.55.0
New features
Performance/UnneededSort
cop. (@parkerfinch)Lint/SafeNavigationConsistency
cop. (@rrosenblum)Bug fixes
Performance/RegexpMatch
cop not correcting negated match operator. (@bdewater):class_name
option in Rails/InverseOf cop. (@bdewater)Style/SymbolArray
andStyle/WordArray
for multiline Arrays. (@istateside)Rails/InverseOf
cop allowinginverse_of: nil
to opt-out. (@bdewater)Lint/ShadowedArgument
false positive with shorthand assignments. (@akhramov)Naming/HeredocDelimiterNaming
blacklist patterns. (@mcfisch)Performance/RegexpMatch
to produce code that safe guards against the receiver beingnil
. (@rrosenblum)Rails/HttpStatus
ignoring hash order to fix false negative. (@pocke)Style/EmptyLineAfterGuardClause
when guard clause is after heredoc. (@koic)Style/EmptyLineAfterGuardClause
when guard clause is after heredoc argument. (@koic)Style/Unpackfirst
false positive ofunpack('h*').take(1)
. (@parkerfinch)Style/FrozenStringLiteralComment
auto-correction to insert a new line between the comment and the code. (@rrosenblum)Lint/Void
not detecting void context in blocks with single expression. (@Darhazer)Changes
String#delete_{prefix,suffix}
to Lint/Void cop. (@bdewater)by
,on
,in
andat
to allowed names ofNaming/UncommunicativeMethodParamName
cop in default config. (@AlexWayfer)EnforcedStyle
option toLayout/SpaceInsideParens
, allowing you to enforce spaces inside of parentheses. (@joshuapinter)Metrics/BlockLength
'sExcludedMethods
configuration option. (@akhramov)IgnoredMethods
option toStyle/MethodCallWithoutArgsParentheses
cop. (@Darhazer)Style/OptionHash
aware of implicit parameter passing to super. (@Wei-LiangChew)Not all release notes shown. View the full release notes
Commits
See the full diff on Github. The new version differs by 23 commits:
Cut 0.59.2
Fix a changelog entry
Allow to exclude methods from `Metrics/MethodLength` (#6286)
Fix a false negative for `Rails/HasManyOrHasOneDependent`
Remove Travis configuration file
Restyle example formatting for `Rails/Delegate`
Merge pull request #6320 from lukasz-wojcik/fix-for-style-cop-with-range
[Fix #6316] Fix auto-correct for `Style/For` cop
Update the links to the manual
[Fix #6311] Prevent Style/Semicolon from breaking on single line if-then-else in assignment (#6317)
Fix an error for `Rails/HasManyOrHasOneDependent`
[Fix #6007] Fix false positive in Style/IfUnlessModifier when using named capture
MemoizedInstanceVariableName: Fix doc typo
[Fix #6305] Fix infinite loop for `Layout/EmptyLinesAroundAccessModifier`
[Fix #5303] Create PercentLiteralCorrector (#6299)
Fix `AllowURI` option for `Metrics/LineLength` cop with disabled `Layout/Tab` cop (#6287)
Fix a couple of changelog entries
[Fix #6266] Run HasManyOrHasOneDependent only for ActiveRecord class
Move inspection of class- and module definition block length
[Fix #6300] Fix a false positive for `Layout/EmptyLineAfterGuardClause`
[Fix #2841] Reduce Style/ZeroLengthPredicate false positives
Merge pull request #6297 from autopp/fix-auto-correct-of-style-for
[Fix #6296] Fix an auto-correct error for `Style/For` when setting `EnforcedStyle: each` and `for` dose not have `do` or semicolon
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.