Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Consider config/environment changes (2.0) #93

Closed
timkelty opened this issue Sep 29, 2015 · 4 comments
Closed

Consider config/environment changes (2.0) #93

timkelty opened this issue Sep 29, 2015 · 4 comments
Assignees
Milestone

Comments

@timkelty
Copy link
Member

Currently all options from default and your target env are merged together.

However, it may be desirable to maintain separate settings between your local environment and a remote server.

For example, shipit-db, which syncs mysql db between local and remote. To achieve this currently, I have options like shipit.config.db.remote and shipit.config.db.local. E.g. https://github.com/timkelty/shipit-db#example-shipitfilejs

It works, but seems less than ideal for each plugin to have to do that.

How about if we merge everything as we do now, but keep the other environments' still accessible via shipit.config.environments or something?

Seems the most flexible without breaking anything. Open to any other ideas.

@gregberge
Copy link
Member

I don't understand what do you mean by merging.

@timkelty
Copy link
Member Author

Currently, a Shipit instance (shipit), has a shipit.config property which is the result of the environment config, merged with the default config.

@gregberge
Copy link
Member

@timkelty ok and you just want to keep an access to the original environments config, yes it's OK for me.

@timkelty
Copy link
Member Author

@neoziro Right. I'll work on a PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants