Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove banned NPM advertisement #65

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Remove banned NPM advertisement #65

merged 1 commit into from
Sep 27, 2020

Conversation

kpfefferle
Copy link
Contributor

Resolves #64

@RobbieTheWagner RobbieTheWagner merged commit 965e687 into shipshapecode:master Sep 27, 2020
@kpfefferle
Copy link
Contributor Author

I see that the version was bumped to 2.7.2 after this was merged, but 2.7.1 is still the latest published to NPM. Can we get 2.7.2 published? Thanks!

@RobbieTheWagner
Copy link
Member

@kpfefferle I used release-it which is supposed to do all the publishing, and has worked in the past. Not sure what happened here. Will try it again.

@kpfefferle
Copy link
Contributor Author

@rwwagner90 I'm seeing 2.7.2 on NPM now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPM does not allow ads to be displayed on installation
2 participants
@kpfefferle @RobbieTheWagner