Skip to content

Commit

Permalink
Don't retry flakes in integration tests
Browse files Browse the repository at this point in the history
Flaky behavior can hurt real users, and ignoring it to appease CI tests
only hides the problem, and can make CI tests take longer.

If this is too noisy, we can either spend effort fixing flakes, and/or
make tests less strict, or re-enable flaky retries.
  • Loading branch information
imjasonh committed Feb 4, 2021
1 parent 6d8f56e commit 1951f7c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ TEKTON_VERSION ?= v0.20.1
SDK_VERSION ?= v0.17.0

# E2E test flags
TEST_E2E_FLAGS ?= -failFast -flakeAttempts=2 -p -randomizeAllSpecs -slowSpecThreshold=300 -timeout=30m -progress -stream -trace -v
TEST_E2E_FLAGS ?= -failFast -p -randomizeAllSpecs -slowSpecThreshold=300 -timeout=30m -progress -stream -trace -v

# E2E test operator behavior, can be start_local or managed_outside
TEST_E2E_OPERATOR ?= start_local
Expand Down Expand Up @@ -219,7 +219,6 @@ test-integration: install-apis ginkgo
-randomizeAllSpecs \
-randomizeSuites \
-failOnPending \
-flakeAttempts=2 \
-slowSpecThreshold=240 \
-trace \
test/integration/...
Expand Down

0 comments on commit 1951f7c

Please sign in to comment.