Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes and Tekton #1093

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Aug 15, 2022

Changes

Updating the CI runs to use KinD v0.14 and test with Kubernetes v1.23 and Tekton v0.38.3.

Updating support statement in README to state that we support Kubernetes v1.22 to v1.24 (those are currently in support, https://kubernetes.io/releases/).

Updating support statement in README to state that we support Tekton v0.36 to v0.38. This choice was made because v0.36 introduced the different result types where a string was changed to ArrayOrString. I know that older client code works with the new Tekton backend, but I do not know if that is true vice-versa and I don't think we will need to support such an old Tekton version in our project state.

Another notable difference is that Tekton now does NOT anymore use the Container type from Kubernetes but copied all the fields into its Step. Something that I am also going to put on our Beta API discussion.

I had to put in a workaround to make Kaniko running on the new KinD/k8s versions, for GoogleContainerTools/kaniko#2164.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Updated the support statement to the current Kubernetes and Tekton version

@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Aug 15, 2022
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Aug 15, 2022
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-kubernetes-update branch 4 times, most recently from ae1d977 to 9af8e8b Compare August 16, 2022 08:50
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit da9d013 into shipwright-io:main Aug 16, 2022
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.11.0 milestone Sep 2, 2022
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-kubernetes-update branch February 18, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants