add pull request template to integrate with prow release-note plugin

[gabemontero]

To mimic upstream tekton on how they curate release notes on a per PR basis using the prow release-note plugin

Related PR: openshift/release#15770

/assign @adambkaplan

/assign @qu1queee

@sbose78 FYI

ultimately what happens is a release-note or release-note-none label is required for PR merge, and which label is applied is triggered by what is placed in the release-note description of the PR.

[gabemontero]

FYI openshift/release#15770 was merged sooner than I had intended (the test platform guys merged it when I was only trying to get them to add the approved label)

Short term, I've added the release-note-none label so PRs can still merge prior to landing some form of this PR. Or folks can manually add the release-note block per https://git.k8s.io/community/contributors/guide/release-notes.md

[adambkaplan]

nit: /s/contribution/contributor/

[adambkaplan]

Shouldn't this also be in an HTML comment?

[gabemontero]

switched to contributor in next push

[gabemontero]

it was not a HTML comment in the the version in upstream Tekton I borrowed from @adambkaplan

See https://raw.githubusercontent.com/tektoncd/triggers/master/.github/pull_request_template.md
for example

[gabemontero]

but if the majority is to break from with that pattern and make this an HTML comment I'll defer and update accordingly

[adambkaplan]

Given the title is "Submitter checklist", I would expect there to be an actual checklist that contributors could mark off, such as:

- [ ] Includes tests if functionality changed/was added
- [ ] Includes docs if changes are user-facing
- [ ] Release notes block has been filled in, or marked NONE

[gabemontero]

check list added @adambkaplan thanks

[gabemontero]

pushed everything besides the HTML comment note @adambkaplan (while that is still a pending discussion)

[gabemontero]

Validations of the plugin via #590 look good

• do-not-merge label shows up by default
• if a release-note-none label is added the do-not-merge label is removed and tide does not block
• you cannot add the release-note label manually without having the appropriate block in the description
• once you add the release-note block in the description, the release-note label is added and any other related labels are removed

[gabemontero]

Also tried to explore some github action variants. The closest thing I could find was https://github.com/marketplace/actions/pull-request-updater-github-action

Maybe it could accomplish what we need (though I could not say for sure). The pre-action thing here seem much more simpler / direct.

[qu1queee]

looks good, just a minor typo from my side that needs to be fixed.

[qu1queee]

/lgtm

[gabemontero]

there is a lot of tl;dr discussion in https://kubernetes.slack.com/archives/C019ZRGUEJC/p1613143894064100
including details on how tekton processes the release-note and kind labels, as well as some possible github action stuff down the line to try

[gabemontero]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adambkaplan]

/lgtm

[gabemontero]

can we re-run the travis job if it flakes with an unrelated error?

[gabemontero]

can we re-run the travis job if it flakes with an unrelated error?

found https://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit ... seeing if any of those is available

[gabemontero]

can we re-run the travis job if it flakes with an unrelated error?

found https://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit ... seeing if any of those is available

Yeah none of the options there are available. I'm going to refrain from hitting the merge button until can ask the community on Monday, of if someone responds here beforehand.

[adambkaplan]

@gabemontero I think repo owners can restart the build in Travis. I just did.

[gabemontero]

@gabemontero I think repo owners can restart the build in Travis. I just did.

thanks @adambkaplan

[gabemontero]

docker throttling with latest travis run

docker: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.