New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warnings for .spec.runtime #796
Add deprecation warnings for .spec.runtime #796
Conversation
I'd love to get this in before we cut v0.5.0 but I don't feel strongly about it if that train's already leaving the station. |
96c4520
to
f9a0737
Compare
@imjasonh pls rebase on top of main, to decrease the changes on the CRDs please |
1674092
to
e1821f0
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
Marks the
runtime
field asDeprecated
in docs and Go doc commentsFirst step of SHIP-0002
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes