Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CI with README updates #804

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Jun 13, 2021

Changes

This will open a new PR based on README updates.

The PR will contain updates that point to the latest tag created when shipping a new release. This should avoid people committing manual Readme updates, see examples:

Example of PR generated with changes: qu1queee#24

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Enhance CI with automated README updates

@qu1queee qu1queee added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 13, 2021
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Jun 13, 2021
@qu1queee qu1queee force-pushed the qu1queee/ci_101 branch 6 times, most recently from 41cf2c1 to c9e522f Compare June 13, 2021 22:55
@sbose78 sbose78 added this to the v0.5.1 milestone Jun 16, 2021
This will open a new PR based on README updates.
It will update docs to point out to the latest available tag.
@qu1queee qu1queee changed the title WIP: Extend CI with README updates Extend CI with README updates Jun 17, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2021
@qu1queee qu1queee requested review from SaschaSchwarze0 and imjasonh and removed request for adambkaplan and gabemontero June 17, 2021 09:30
.github/workflows/release.yaml Outdated Show resolved Hide resolved
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit f7667c2 into shipwright-io:main Jun 17, 2021
@qu1queee qu1queee deleted the qu1queee/ci_101 branch June 17, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants