-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Tekton Release to v0.25.0 #805
Bump Tekton Release to v0.25.0 #805
Conversation
Do we also want to bump https://github.com/shipwright-io/build/blob/main/Makefile#L36 ? This makes me think we might want to automate this so we don't forget other places this version is specified. 🤔 |
Yes, this PR will include all related changes. The automation is nice, but as we have hard dependencies to Tekton, I like to review manually the upcoming changes when working on the bump. I will add this topic to #812 for now. |
160d090
to
f6e8f74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding hold as we might want to do this after v0.5.1 while we are not prepared to build a release from a non-main branch? Also omitting risk by claiming support for a very fresh Tekton version. But open to get it into v0.5.1. Just think we should agree on that before we merge.
fyi @HeavyWombat the env var override in our buildkit experiments that we manually had to do to revert the Tekton override is then becoming obsolete.
/approve
/hold
it does make sense, lets merge after. |
@SaschaSchwarze0 this one should be now ready to get in, fyi |
Hi @qu1queee, I tested this in my local cluster where Tekton is at v0.25 as well and I get BuildKit only working by also setting the |
5b62e22
to
4037eaf
Compare
54d8f26
to
62b308a
Compare
Latest stable Tekton Release
62b308a
to
9c5d697
Compare
Reflect changes to new release version
Some of the strategies tooling require to have a defined HOME env var pointing to /tekton/home for getting the access to the container registry.
9c5d697
to
f38b98a
Compare
@SaschaSchwarze0 correct, buildkit didnt worked for me either. Done. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Bump to latest stable Tekton Release.
The v0.24 have 3 patches, I only found one breaking change, as follows:
https://github.com/tektoncd/pipeline/pull/3878
, we are not affected on the removal of a HOME env var with/tekton/home
value, neither the removal of default workingDir with/workspace
value. I modified our strategies where the ENV var was needed.Regarding v0.25.0, I didnt find any significant change for SHP.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes