Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Tekton Release to v0.25.0 #805

Merged

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Jun 13, 2021

Changes

Bump to latest stable Tekton Release.

The v0.24 have 3 patches, I only found one breaking change, as follows:

  • Related to https://github.com/tektoncd/pipeline/pull/3878, we are not affected on the removal of a HOME env var with /tekton/home value, neither the removal of default workingDir with /workspace value. I modified our strategies where the ENV var was needed.

Regarding v0.25.0, I didnt find any significant change for SHP.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Bump Tekton to v0.25.0 release

@qu1queee qu1queee added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2021
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Jun 13, 2021
@SaschaSchwarze0
Copy link
Member

fyi @qu1queee v0.25.0 got released today. Don't see anything in its release notes that would block us from directly going there.

@imjasonh
Copy link
Contributor

Do we also want to bump https://github.com/shipwright-io/build/blob/main/Makefile#L36 ?

This makes me think we might want to automate this so we don't forget other places this version is specified. 🤔

@qu1queee
Copy link
Contributor Author

Yes, this PR will include all related changes. The automation is nice, but as we have hard dependencies to Tekton, I like to review manually the upcoming changes when working on the bump. I will add this topic to #812 for now.

@qu1queee qu1queee changed the title WIP: Bump Tekton Release to v0.24.3 WIP: Bump Tekton Release to v0.25.0 Jun 17, 2021
@qu1queee qu1queee changed the title WIP: Bump Tekton Release to v0.25.0 Bump Tekton Release to v0.25.0 Jun 17, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2021
@qu1queee qu1queee requested review from imjasonh and SaschaSchwarze0 and removed request for adambkaplan June 17, 2021 10:24
@qu1queee qu1queee added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Jun 17, 2021
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding hold as we might want to do this after v0.5.1 while we are not prepared to build a release from a non-main branch? Also omitting risk by claiming support for a very fresh Tekton version. But open to get it into v0.5.1. Just think we should agree on that before we merge.

fyi @HeavyWombat the env var override in our buildkit experiments that we manually had to do to revert the Tekton override is then becoming obsolete.

/approve
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 17, 2021
@qu1queee
Copy link
Contributor Author

@SaschaSchwarze0

Adding hold as we might want to do this after v0.5.1 while we are not prepared to build a release from a non-main branch? Also omitting risk by claiming support for a very fresh Tekton version. But open to get it into v0.5.1. Just think we should agree on that before we merge.

it does make sense, lets merge after.

@qu1queee qu1queee added this to the release-v0.6.0 milestone Jun 17, 2021
@qu1queee
Copy link
Contributor Author

@SaschaSchwarze0 this one should be now ready to get in, fyi

@qu1queee qu1queee removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2021
@SaschaSchwarze0
Copy link
Member

Hi @qu1queee, I tested this in my local cluster where Tekton is at v0.25 as well and I get BuildKit only working by also setting the HOME environment variable explicitely to /tekton/home as you do for the other build strategies. I also guess that we must set the environment variable here: runtime_image.go#L198-L202, I know the feature is deprecated, but it is still there.

@SaschaSchwarze0 SaschaSchwarze0 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@SaschaSchwarze0 SaschaSchwarze0 self-requested a review June 23, 2021 19:50
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 24, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2021
Latest stable Tekton Release
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2021
Reflect changes to new release version
Some of the strategies tooling require to have a defined
HOME env var pointing to /tekton/home for getting the access
to the container registry.
@qu1queee
Copy link
Contributor Author

@SaschaSchwarze0 correct, buildkit didnt worked for me either. Done.

@SaschaSchwarze0
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2a3a235 into shipwright-io:main Jun 24, 2021
@qu1queee qu1queee deleted the qu1queee/tekton_bmp branch June 24, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants