Remove runtime feature #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
HeavyWombat
requested review from
HeavyWombat and
SaschaSchwarze0
and removed request for
qu1queee
HeavyWombat
requested changes
Jul 23, 2021
There was a problem hiding this comment.
Thanks for tackling this issue. I think we can safely remove all references to this feature since we "properly" deprecated it. With that in mind, I think we should:
- remove
test/data/build_buildpacks-v3_nodejs_runtime-image_cr.yaml, - and the runtime image section.
SaschaSchwarze0
added
the
kind/api-change
Done, sorry for the delay on this. |
imjasonh
force-pushed
the
remove-runtime
branch
from
a1e395f
to
f1d91b9
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes the
.spec.runtimefield that was marked as deprecated in v0.5.0, as described in https://github.com/shipwright-io/community/blob/main/ships/0002-deprecate-runtime.md#516
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes