Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

December 11th, 2023 Community Meeting #180

Closed
qu1queee opened this issue Dec 6, 2023 · 3 comments
Closed

December 11th, 2023 Community Meeting #180

qu1queee opened this issue Dec 6, 2023 · 3 comments

Comments

@qu1queee
Copy link
Contributor

qu1queee commented Dec 6, 2023

  • Please add a topic in this thread and add a link to the GitHub issue associated with the topic.
  • Please make sure you give folks enough time to review/discuss the topic offline on GitHub before coming into the meeting
  • (optional) Paste the image of an animal 😸
@qu1queee
Copy link
Contributor Author

qu1queee commented Dec 7, 2023

  • Updates regarding our path to CNCF from my side. 🎅
  • On v0.13.0 release, let's rock n roll. 🎅

@SaschaSchwarze0
Copy link
Member

SaschaSchwarze0 commented Dec 11, 2023

API change on .spec.source.git.url to required. The k8s sig-architecture documents that a change of a field from required to not and vice versa is considerer incompatible. Though, their documentation mainly talks about API calls (e. g. Any API call (e.g. a structure POSTed to a REST endpoint) that succeeded before your change must succeed after your change.) which means that the relevant part if the JSON/YAML serialized format and not the Go types.

With that, I suggest that we change it.

BTW, when creating this beta Build:

apiVersion: shipwright.io/v1beta1
kind: Build
spec:
  source:
    git:
      cloneSecret: deploy-key
    type: Git

then the converted Alpha build is:

apiVersion: shipwright.io/v1alpha1
kind: Build
spec:
  source:
    credentials:
      name: deploy-key
status:
  message: all validations succeeded
  reason: Succeeded
  registered: "True"

Both make no sense and it is probably a bug that we register it as successful. Running this build will run without source step.

@qu1queee
Copy link
Contributor Author

Meeting minutes:

  • On CNCF, we have a draft for the application. We took a detail look and generated some todos. We will continue on this. The draft is not public, @qu1queee to make it publicly available this week.
  • On v0.13.0, to have the setup ready for refinement. This implies, all milestones across projects, all required issues and proper labels. The management of the release will be handle via the https://github.com/orgs/shipwright-io/projects/6.
  • On December 11th, 2023 Community Meeting  #180 (comment) , we will move forward with the API changes in v1beta1, as there is none concern on the go types, but mainly on the JSON/YAML serialisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants