Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.20 for release #165

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Update to go 1.20 for release #165

merged 1 commit into from
Oct 30, 2023

Conversation

adambkaplan
Copy link
Member

Changes

Update go version in the release workflow. This was missed in the go bump pull request.

See #161

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@adambkaplan
Update to go 1.20 for release
e9cad09 
Update go version in the release workflow. This was missed in the go
bump pull request.
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2023
@adambkaplan
Copy link
Member Author

/kind cleanup

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 30, 2023
@adambkaplan
Copy link
Member Author

/assign @qu1queee

/cc @jkhelil

@openshift-ci openshift-ci bot requested a review from jkhelil October 30, 2023 15:16
@qu1queee qu1queee self-requested a review October 30, 2023 15:44
qu1queee
qu1queee approved these changes Oct 30, 2023
View reviewed changes
Copy link

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@openshift-ci openshift-ci bot merged commit 9567f53 into shipwright-io:main Oct 30, 2023
5 checks passed
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

@otaviof otaviof Awaiting requested review from otaviof

@jkhelil jkhelil Awaiting requested review from jkhelil

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adambkaplan @qu1queee @SaschaSchwarze0