Target build asset for the Buildpack when using the environment variable #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a Buildpacke e2e test in the https://github.com/shipwright-io/build repo that sets the BP_GO_TARGETS environment variable.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
4 tasks
shahulsonhal
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/assign@adambkaplan @adambkaplan the approve (and maybe automatic merge) still does not work here. |
|
/assign adambkaplan |
SaschaSchwarze0
requested changes
Oct 18, 2021
There was a problem hiding this comment.
Sry, just noticed your directory structure. I think this needs to change. Imo building with contextDir=source-build without BP_GO_TARGETS will work because there is a main.go inside source-build. But we want a build config that fails if the env var is no set. So, imo you need to move it to a new directory, like /source-build-with-package/main-package
|
Green button merging - looks like this was not fully integrated with OpenShift's CI system (which provides all of the prow commands and tide integration). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a Buildpacke e2e test in the shipwright-io/build repo that sets the
BP_GO_TARGETSenvironment variable.Note: See here the test case that uses the introduced changes.