Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][cms][workflow] invalid url in approval email sent from preview #3187

Merged
merged 3 commits into from Sep 17, 2019

Conversation

sunny4381
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 80.838% when pulling ab8609f on fixes/gws-workflow-notice-url into 33a32a9 on master.

@sunny4381 sunny4381 changed the title [fix][cms][workflow] invalid url in approval email sent from preview [WIP][fix][cms][workflow] invalid url in approval email sent from preview Sep 13, 2019
@sunny4381 sunny4381 changed the title [WIP][fix][cms][workflow] invalid url in approval email sent from preview [fix][cms][workflow] invalid url in approval email sent from preview Sep 17, 2019
@sunny4381 sunny4381 merged commit 61f10f0 into master Sep 17, 2019
@sunny4381 sunny4381 deleted the fixes/gws-workflow-notice-url branch September 17, 2019 06:36
itowtips pushed a commit to itowtips/shirasagi that referenced this pull request Mar 10, 2020
#2)

* [fix][cms][workflow] invalid url in approval email sent from preview (shirasagi#3187)

* [add] reproducible specs

* [fix] workflow notice path is full url

* [fix] invalid url in approval email from preview

(cherry picked from commit 61f10f0)

* [fix] workflow mailer url with preview form

Co-authored-by: NAKANO Hideo <pinarello.marvel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants