Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/log of import facility #3833

Merged
merged 30 commits into from Feb 16, 2021
Merged

Fix/log of import facility #3833

merged 30 commits into from Feb 16, 2021

Conversation

ash0411-maker
Copy link
Contributor

@ash0411-maker ash0411-maker commented Jan 15, 2021

目的

施設インポートの際、更新した内容や登録できなかった項目を確認できるようにログに表示させる。

概要

  • 最終行にerrorの合計数を表示
  • 入力内容に不正な値が入っていたり、空白などでドキュメントを保存できなかった場合「 error ○行目のデータは登録できませんでした。入力内容をもう1度ご確認ください。」と表示。
  • CSVに入力された各項目が「どの行で」「登録」「更新」「登録/更新の失敗」したのか、ログに表示。
    • 新しく1行追加した場合 → add
    • セル内のデータが更新された場合 → update
    • セル内のデータの登録/更新に失敗した場合 → error

ブラウザ上の表示

スクリーンショット 2021-01-18 17 34 28

スクリーンショット 2021-01-15 18 26 20

@coveralls
Copy link

coveralls commented Jan 27, 2021

Coverage Status

Coverage decreased (-0.06%) to 78.168% when pulling 693bbd6 on fix/log_of_import_facility into 9ef7c44 on master.

@sunny4381 sunny4381 merged commit 8a0c5ca into master Feb 16, 2021
@sunny4381 sunny4381 deleted the fix/log_of_import_facility branch February 16, 2021 06:08
ShinjiTanimoto pushed a commit to ShinjiTanimoto/shirasagi that referenced this pull request May 25, 2021
* [fix] import log for facility

* [add] put_log_of_location method

* [add] put_log_of_service method

* [modify] refactor in put_log_of_insertメソッド

* [add] put_log_of_group method

* [remove] .compact at end of method

* [modify] refactor in put_log_of_insert method

* [modify]  restoring inline to shirasagi

* [modify]  restoror stop repeating change_data

* [fix] output log when failing to save a document

* [modify] using a method chain for map method

* [modify] avoid using abstract name

* [modify] avoid using abstract name

* [modify] refactor in put_log_of_insert method

* [add] put_log_of_update method to shorten put_log_of_insert method

* [modify] using early return in put_log_of_update

* [modify] using integer for @count_errors

* [modify] avoid using find to be effecient

* [modify] using changed_field variable

* [modify] delete return to display all update information

* [modify] able to display log for locaiton

* [add] Test for log of facility import

* [add] test import facility for update

* [delete] one of put_log_of_group

* [refactor] get facility name without using map method

* [refactor] Character code specification

* [refactor]

* delete space
@sunny4381 sunny4381 added this to the v.1.14.0 milestone Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants