Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
sxml: remove special handling for html boolean attributes #359
HTML boolean attributes can be specified without a value to represent "true". The presence of the attribute itself is enough to represent true. The value will be ignored (and to represent false, the attribute must not be present).
This special handling for boolean attribute (i.e. hiding the value) causes problems because this code does not really know if the attribute in question is boolean. This code would trip with this element
and render "title" attribute as a boolean, e.g.
which is wrong (i.e. empty title) because it is the same as
Remove this code. This means boolean attribute will be shown with value, e.g.
But semantically this is still correct. And it fixes the mistaking "title" as boolean above.