sxml: remove special handling for html boolean attributes #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML boolean attributes can be specified without a value to represent
"true". The presence of the attribute itself is enough to represent
true. The value will be ignored (and to represent false, the attribute
must _not_ be present).
This special handling for boolean attribute (i.e. hiding the value)
causes problems because this code does not really know if the
attribute in question is boolean. This code would trip with this
element
(a (@ (href "foo") (title "title")))
and render "title" attribute as a boolean, e.g.
<a href="foo" title>
which is wrong (i.e. empty title) because it is the same as
<a href="foo" title="">
Remove this code. This means boolean attribute will be shown with
value, e.g.
<input checked="checked">
But semantically this is still correct. And it fixes the mistaking
"title" as boolean above.
|
It looks like it is from the original sxml code but I think your assessment is valid. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML boolean attributes can be specified without a value to represent "true". The presence of the attribute itself is enough to represent true. The value will be ignored (and to represent false, the attribute must not be present).
This special handling for boolean attribute (i.e. hiding the value) causes problems because this code does not really know if the attribute in question is boolean. This code would trip with this element
and render "title" attribute as a boolean, e.g.
which is wrong (i.e. empty title) because it is the same as
Remove this code. This means boolean attribute will be shown with value, e.g.
But semantically this is still correct. And it fixes the mistaking "title" as boolean above.