Merge pull request #1090 from MyaLongmire/windows_name_fix

simplify mutex usage
shirou · Jun 29, 2021 · d87e955 · d87e955
2 parents daec167 + cb512c8
commit d87e955
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/process/process.go b/process/process.go
@@ -27,7 +27,7 @@ type Process struct {
 	name           string
 	status         string
 	parent         int32
-	parentMutex    *sync.RWMutex // for windows ppid cache
+	parentMutex    sync.RWMutex // for windows ppid cache
 	numCtxSwitches *NumCtxSwitchesStat
 	uids           []int32
 	gids           []int32
@@ -170,8 +170,7 @@ func NewProcess(pid int32) (*Process, error) {
 
 func NewProcessWithContext(ctx context.Context, pid int32) (*Process, error) {
 	p := &Process{
-		Pid:         pid,
-		parentMutex: new(sync.RWMutex),
+		Pid: pid,
 	}
 
 	exists, err := PidExistsWithContext(ctx, pid)

diff --git a/v3/process/process.go b/v3/process/process.go
@@ -27,7 +27,7 @@ type Process struct {
 	name           string
 	status         string
 	parent         int32
-	parentMutex    *sync.RWMutex // for windows ppid cache
+	parentMutex    sync.RWMutex // for windows ppid cache
 	numCtxSwitches *NumCtxSwitchesStat
 	uids           []int32
 	gids           []int32
@@ -181,8 +181,7 @@ func NewProcess(pid int32) (*Process, error) {
 
 func NewProcessWithContext(ctx context.Context, pid int32) (*Process, error) {
 	p := &Process{
-		Pid:         pid,
-		parentMutex: new(sync.RWMutex),
+		Pid: pid,
 	}
 
 	exists, err := PidExistsWithContext(ctx, pid)