Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Separate subdirectory #24

Closed
shirou opened this issue Nov 2, 2014 · 4 comments
Closed

[RFC] Separate subdirectory #24

shirou opened this issue Nov 2, 2014 · 4 comments

Comments

@shirou
Copy link
Owner

shirou commented Nov 2, 2014

I write all files under the root directory. But each part is not related and some user may want to use just a/some feature.

I want to separate to subdirectory like

gopsutil
   - common
        - common_linux.go
        - common_freebsd.go
   - host
        - host_linux.go
        - host_freebsd.go
   - disk
        - disk_linux.go
        - disk_linux.go

I know this will break compatibility. But I think it can be more structured and become easy to maintain and enhance.
How do you feel it? please tell what you think.

@logavanc
Copy link
Contributor

First off, thank you for making this package! =)

For what it is worth, I think organizing like that would make the project look very structured and nice. It could also reduce the compiled size of applications when they only use a single component (like memory when cpu information isn't needed). I say go for it!

@shirou
Copy link
Owner Author

shirou commented Nov 23, 2014

Thank you for the comment.

Then, I'll make that changes on the some branch. and will merge into the master at end or middle of Dec, 2014.

shirou added a commit that referenced this issue Nov 27, 2014
@shirou
Copy link
Owner Author

shirou commented Nov 27, 2014

I'm working on separate_directories branch.

@shirou
Copy link
Owner Author

shirou commented Dec 31, 2014

package structure has been changed on the master.

@shirou shirou closed this as completed Dec 31, 2014
jeffweiss pushed a commit to jeffweiss/gopsutil that referenced this issue Feb 7, 2023
Explicitly type RSS and VMS values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants