Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestVirtualization: fails in machines not having virtualization support (?) #547

Closed
onlyjob opened this issue Jul 5, 2018 · 2 comments
Closed

TestVirtualization: fails in machines not having virtualization support (?) #547

onlyjob opened this issue Jul 5, 2018 · 2 comments

Comments

@onlyjob
Copy link

onlyjob commented Jul 5, 2018

As reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902563
TestVirtualization seems to fail in machines without virtualization support:

--- FAIL: TestVirtualization (0.00s)
        host_test.go:137: Virtualization() retuns empty system or role:  , 
        host_test.go:140: Virtualization(): ,
shirou added a commit that referenced this issue Jul 5, 2018
@shirou
host: remove empty virtualzation check.
4923bd2 
related to #547
There is an architecture which supports no virtualization.
@shirou
Copy link
Owner

shirou commented Jul 5, 2018

Thank you for your report! That empty check confirms there is an return value. But as you suggested, if a machine does not support virtualization, it failed. And we already has err check, so I have removed that check on 4923bd2

@shirou shirou closed this as completed Jul 5, 2018
@onlyjob
Copy link
Author

onlyjob commented Jul 5, 2018

Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shirou @onlyjob