Add swapdevices method #1120
Merged
Add swapdevices method #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirou
requested changes
Aug 28, 2021
| } | ||
|
|
||
| func SwapDevicesWithContext(ctx context.Context) ([]*SwapDevice, error) { | ||
| output, err := exec.Command(swapCommand, "-lk").Output() |
There was a problem hiding this comment.
Could you use exec.LookPath like here?
| } | ||
|
|
||
| func SwapDevicesWithContext(ctx context.Context) ([]*SwapDevice, error) { | ||
| f, err := os.Open(swapsFilePath) |
There was a problem hiding this comment.
Could you change to common.HostProc("swaps") like here? It can enable to run on container environment.
| } | ||
|
|
||
| func SwapDevicesWithContext(ctx context.Context) ([]*SwapDevice, error) { | ||
| output, err := exec.Command(swapsCommand, "-l").Output() |
There was a problem hiding this comment.
same here, please use exec.LookPath.
|
Hi @shirou. I work with @tbarker25 and am continuing his work in #1131 (because he will be away from work for the next several weeks). I've incorporated your feedback in that PR, please let me know if you're okay with merging it. |
shirou
added a commit
that referenced
this pull request
Sep 29, 2021
Add swapdevices method (continued from #1120)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mem.SwapDevices() method to get swap stats per device. See #1115.
Unfortunately I could not find a way to implement this in Darwin, so I have left that as unimplemented.
Note that I have run these tests on the following OSs and verified that they passed: Linux, MacOS, FreeBSD, OpenBSD and Solaris.