Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename readdrivestat function on v3 #1137

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

mx-psi
Copy link
Contributor

@mx-psi mx-psi commented Sep 29, 2021

  • Rename readdrivestat function on v3 to v3readdrivestat
  • Delete unused extern declaration readcpustat.

This fixes #1136.

Signed-off-by: Pablo Baeyens pablo.baeyens@datadoghq.com

Signed-off-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you so much. By the way, we have a plan to terminate v2 (#1078). (yes, this PR is important because after terminated, some user want to use v2)

Thank you so much!

@@ -29,5 +29,4 @@ struct CPUStats {
natural_t idle;
};

extern int readdrivestat(DriveStats a[], int n);
extern int readcpustat(CPUStats *cpu);
extern int v3readdrivestat(DriveStats a[], int n);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memo: readcpustat is removed, but it is not used.

@shirou shirou merged commit 532241f into shirou:master Sep 29, 2021
@mx-psi mx-psi deleted the mx-psi/fix-duplicate-symbol branch September 29, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2 and 3 of the library should have different symbol names
2 participants