[mem][linux] added additional meminfo fields #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support HugePages_Rsvd, HugePages_Surp Signed-off-by: quanweiZhou <quanweiZhou@linux.alibaba.com>
shirou
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Thank you and sorry to late response. These are Linux specific values and we don't want to add such a platform specific information. However, HugePagesTotal, HugePagesFree, and HugePageSize are already added (in 2018). So, I don't like it very much, but I make a hard decision about adding those information to ensure consistency. Anyway, thank you for your contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support HugePages_Rsvd, HugePages_Surp
Signed-off-by: quanweiZhou quanweiZhou@linux.alibaba.com