Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestions/additions for JOSS paper #169

Merged
merged 5 commits into from
Jun 25, 2021
Merged

suggestions/additions for JOSS paper #169

merged 5 commits into from
Jun 25, 2021

Conversation

mrshirts
Copy link
Contributor

@mrshirts mrshirts commented Jun 8, 2021

Still need affiliation of Simon, sent him a slack message to ask

Still need affiliation of Simon, sent him a slack message to ask
@mrshirts mrshirts requested a review from ptmerz June 8, 2021 19:46
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #169 (adad106) into joss-paper (7243888) will not change coverage.
The diff coverage is n/a.

❗ Current head adad106 differs from pull request most recent head 86dab80. Consider uploading reports for the commit 86dab80 to get more accurate results

joss/paper.md Outdated Show resolved Hide resolved
@ptmerz ptmerz merged commit 9957983 into joss-paper Jun 25, 2021
ptmerz pushed a commit that referenced this pull request Nov 8, 2021
ptmerz pushed a commit that referenced this pull request Nov 21, 2021
ptmerz pushed a commit that referenced this pull request Nov 29, 2021
ptmerz pushed a commit that referenced this pull request Jan 3, 2022
ptmerz added a commit that referenced this pull request Jan 3, 2022
* Initial paper commit

* Updated author list

* suggestions/additions for JOSS paper (#169)

* Fix references

* Update paper.md (#195)

Adding some funding acknowledgements.

* Address JOSS reviewer comments (#198)

Addresses reviewer comments of first pre-review by fixing references
and explaining relation to prior work.

* Fix one word (paper -> package).

* Added a word

* Address reviewer comments

* Split the "Statement of need" section
* Add GROMACS citation

* Address reviewer comment by renaming "Prior work" to "Relation to prior work" for added clarity

* Implement editorial suggestions

Co-authored-by: Michael Shirts <mrshirts@gmail.com>
@ptmerz ptmerz deleted the mrs_joss_comments branch January 3, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants