Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paper.md #195

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Update paper.md #195

merged 1 commit into from
Nov 29, 2021

Conversation

mrshirts
Copy link
Contributor

@mrshirts mrshirts commented Nov 24, 2021

Adding some funding acknowledgements.

Description

Adding some suggestions for funding acknowledgments.

Status

  • Ready to go

@mrshirts
Copy link
Contributor Author

@ptmerz, I realized that there should be some acknowledgements added here for funding sources for the other authors. I'm not sure the timing for merging this in terms of the JOSS submission - maybe you can figure that out.

Adding some funding acknowledgements.
Copy link
Member

@ptmerz ptmerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @mrshirts!

I wanted to investigate the test failures that popped up recently before resubmitting, so no problem getting this in still.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #195 (0749e2b) into joss-paper (84c7c1e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@ptmerz ptmerz merged commit 648e72b into joss-paper Nov 29, 2021
@ptmerz ptmerz deleted the mrshirts-acknowledge-joss branch December 23, 2021 18:58
ptmerz pushed a commit that referenced this pull request Jan 3, 2022
Adding some funding acknowledgements.
ptmerz added a commit that referenced this pull request Jan 3, 2022
* Initial paper commit

* Updated author list

* suggestions/additions for JOSS paper (#169)

* Fix references

* Update paper.md (#195)

Adding some funding acknowledgements.

* Address JOSS reviewer comments (#198)

Addresses reviewer comments of first pre-review by fixing references
and explaining relation to prior work.

* Fix one word (paper -> package).

* Added a word

* Address reviewer comments

* Split the "Statement of need" section
* Add GROMACS citation

* Address reviewer comment by renaming "Prior work" to "Relation to prior work" for added clarity

* Implement editorial suggestions

Co-authored-by: Michael Shirts <mrshirts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants