Move app dependencies to requirements.txt #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many developers expect a requirements.txt file to be present in a project in order to get a quick overview of the application's dependencies and to be able to do a light-weight install of an application for development via `pip install -r requirements.txt`. Moving the dependencies out of setup.py also increases separation of concerns in the project.
|
Thanks @c-w |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many developers expect a requirements.txt file to be present in a project in order to get a quick overview of the application's dependencies and to be able to do a light-weight install of an application for development via
pip install -r requirements.txt.Moving the dependencies out of setup.py also increases separation of concerns in the project and it's very simple to parse requirements.txt in setup.py, so really there's little downside to moving the dependencies into its own file.