Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move app dependencies to requirements.txt #16

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Oct 20, 2017

Many developers expect a requirements.txt file to be present in a project in order to get a quick overview of the application's dependencies and to be able to do a light-weight install of an application for development via pip install -r requirements.txt.

Moving the dependencies out of setup.py also increases separation of concerns in the project and it's very simple to parse requirements.txt in setup.py, so really there's little downside to moving the dependencies into its own file.

Move app dependencies to requirements.txt
Many developers expect a requirements.txt file to be present in a
project in order to get a quick overview of the application's
dependencies and to be able to do a light-weight install of an
application for development via `pip install -r requirements.txt`.
Moving the dependencies out of setup.py also increases separation of
concerns in the project.
@shivam043

This comment has been minimized.

Copy link
Owner

commented Oct 24, 2017

Thanks @c-w

@shivam043 shivam043 merged commit 46b889c into shivam043:master Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.