Added if condition for hasAttachments

[aarahmanqa]

No description provided.

[shivam1608]

Edit this and the pull request to issue #8 with the required changes for now

[shivam1608]

 if(hasAttachments) {
            JSONArray attachmentArray = (JSONArray) parser.parse(json.get("attachments").toString());
            Object[] aArray = attachmentArray.toArray();

            for (Object attachmentObject : aArray) {
                JSONObject object = (JSONObject) attachmentObject;
                 ... 
                attachments.add(new Attachment(aId, aFilename, aContentType, aDisposition, aTransferEncoding, aRelated, aSize, aDownloadUrl, bearerToken));
            }
        }

here it would be better if you do it like this .. instead of wrapping it in whole if statement you can have the array as empty or filled.
it would not loop with 0 elements and will make the code more readable

          JSONArray attachmentArray = (JSONArray) parser.parse(json.get("attachments").toString());
          Object[] aArray = new Object[0];
          if(hasAttachments) {
                 aArray = attachmentArray.toArray();
          }
          
          for (Object attachmentObject : aArray) {
              JSONObject object = (JSONObject) attachmentObject;
               ... 
              attachments.add(new Attachment(aId, aFilename, aContentType, aDisposition, aTransferEncoding, aRelated, aSize, aDownloadUrl, bearerToken));
          }

[aarahmanqa]

@shivam1608 , the issue is exactly at
json.get("attachments")
attachments field is null leading to NPE. In the suggested change, we would still get NPE.

[shivam1608]

@aarahmanqa sorry my bad I was using the web interface to edit I forgot to copy the json.get() Inside of if statement you can work around that I think you get what I am trying to say

[aarahmanqa]

@shivam1608, I have modified it as you had suggested. Kindly check and let me know if any deviation.

[shivam1608]

Nice work 👍. @aarahmanqa thanks for contribution

[shivam1608]

Merged 👍will be included in next stable version.

[jagadeesh1035]

This is sort of an important and critical bug fix and it is needed to released.