upstream #10
Merged
upstream #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated to Okhttp
Domains.getRandomDomain() returns an Domain object. It does not override toString(), so "thisismychoice@"+Domains.getRandomDomain() will be like thisismychoice@me.shivzee.util.Domain@7fb4f2a9 This cause following Exception : javax.security.auth.login.LoginException: Something went wrong while creating account! Try Againjavax.security.auth.login.LoginException: Account Already Exists! Error 422 at me.shivzee.util.JMailBuilder.createAndLogin(JMailBuilder.java:94) To fix this, I called getDomainName() to get real domain name, and it worked fine. :)
Sorry, since I'm in army, all I can use in here is just Eclipse Portable XD
Dev synctask
2. Added created/updated time in ZonedDateTime format
extended features
* Added if condition for hasAttachments * As per review comments, modified the if block to minimal --------- Co-authored-by: aarahman <aarahman@tekion.com>
* Added if condition for hasAttachments * Added safeEval() so that if any field is null calling toString will not cause issue * Changed the primitive data type to Wrapper type in POJO classes --------- Co-authored-by: aarahman <aarahman@tekion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.