Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/qr codes config #123

Merged
merged 4 commits into from
Sep 26, 2021

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Sep 26, 2021

Closes #122

@codecov-commenter
Copy link

Codecov Report

Merging #123 (3fa7548) into develop (483876f) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #123      +/-   ##
=============================================
+ Coverage      97.97%   98.10%   +0.12%     
- Complexity       195      208      +13     
=============================================
  Files             63       67       +4     
  Lines            495      529      +34     
=============================================
+ Hits             485      519      +34     
  Misses            10       10              
Impacted Files Coverage Δ
...tion/QrCode/DefaultErrorCorrectionConfigOption.php 100.00% <100.00%> (ø)
...Config/Option/QrCode/DefaultFormatConfigOption.php 100.00% <100.00%> (ø)
...Config/Option/QrCode/DefaultMarginConfigOption.php 100.00% <100.00%> (ø)
...c/Config/Option/QrCode/DefaultSizeConfigOption.php 100.00% <100.00%> (ø)
...nfig/Option/UrlShortener/ShortCodeLengthOption.php 100.00% <100.00%> (ø)
src/Config/Util/ConfigOptionsValidatorsTrait.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483876f...3fa7548. Read the comment docs.

@acelaya acelaya merged commit 07f1ac8 into shlinkio:develop Sep 26, 2021
@acelaya acelaya deleted the feature/qr-codes-config branch September 26, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for QR code options
2 participants