Three peaks scoring does not count card sequences #111
Comments
|
Thanks for the report. I'm working on a fix. |
Programator2
added a commit
that referenced
this issue
Apr 21, 2019
Score is correctly updated after moving a card to the waste stack or after winning a game. Double counting is prevented by the score_counted variable. see #111
|
I have pushed a fix here: Can you check if it works fine before I merge it into master? |
|
I checked out the branch, did a py2exe build, and played a few games. Scoring seems to work according to rules. One other issue I noticed previously when building from trunk - auto sizing doesn't function and the option dropdown is missing from menu. I guess it's a work in progress. Thanks for your time. |
|
Great, thanks for checking it. Auto sizing works only with Pillow installed, otherwise it's deactivated. |
Merged
Programator2
added a commit
that referenced
this issue
Apr 22, 2019
Score is correctly updated after moving a card to the waste stack or after winning a game. Double counting is prevented by the score_counted variable. see #111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Three peaks with scoring doesn't update hand score for completed card sequences. The score is calculated and updated only once at the end of game but it should be calculated for each played card.
This has been reported on Sourceforge back in 2010 but wasn't fixed.
There's also a FIXME comment in the code referencing bug 2937253.
At first, it seemed like a simple fix but after looking at the source code it looks like it's incomplete. Specifically, I can't find where the
sequenceproperty inThreePeaksclass is incremented and it doesn't seem to be inherited from parent class.The text was updated successfully, but these errors were encountered: